Support of additional suffixes of Fortran files for preprocessing #979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You're right, it seems like the feature was never implemented. Lines 139 to 140 in 80869ad i.e. use the same type package_t
![...]
! type(string_t), allocatable :: macros(:) DELETE
type(preprocess_config_t) :: preprocess
![...]
end type package_tI don't know why the original preprocess implementation had many options in the manifest not in the package, it seems like a straigthforward choice to store them all in the package settings too. |
|
I closes this PR in favour of #982 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential issue: I noted that the option
suffixesin the sectionpreprocessinfpm.tomlis not supported byfpm. Files with suffixes other thanf90orlower(F90)are currently ignored, even if additional suffixes are provided infpm.tomlThis PR will allow a support for additional suffixes for Fortran files that should be preproccessed (e.g. with
cpp).Related with #729